libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1282: Packet driver extensions
Date Sat, 22 Jun 2019 13:28:34 GMT
Kami commented on a change in pull request #1282: Packet driver extensions
URL: https://github.com/apache/libcloud/pull/1282#discussion_r296445802
 
 

 ##########
 File path: libcloud/compute/drivers/packet.py
 ##########
 @@ -88,11 +98,88 @@ class PacketNodeDriver(NodeDriver):
                       'failed': NodeState.ERROR,
                       'active': NodeState.RUNNING}
 
-    def list_nodes(self, ex_project_id):
-        data = self.connection.request('/projects/%s/devices' %
-                                       (ex_project_id),
-                                       params={'include': 'plan'}
-                                       ).object['devices']
+    def __init__(self, key, project=None):
+        # initialize a NodeDriver for Packet using the API token
+        # and optionally the project (name or id)
+        # If project specified we need to be sure this is a valid project
+        # so we create the variable self.project_id
+        super(PacketNodeDriver, self).__init__(key=key, project=None)
 
 Review comment:
   I assume you don't actually want to pass ``project`` keyword argument to the parent class
(``BaseDriver``) constructor, since the parent constructor doesn't support that argument (it
will simply ignore it, but it may confuse people reading the code).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message