libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] michaelperel commented on a change in pull request #1278: [LIBCLOUD-1037] Add Azurite support for Azure Blob Storage driver
Date Tue, 28 May 2019 23:32:36 GMT
michaelperel commented on a change in pull request #1278: [LIBCLOUD-1037] Add Azurite support
for Azure Blob Storage driver
URL: https://github.com/apache/libcloud/pull/1278#discussion_r288337851
 
 

 ##########
 File path: libcloud/storage/drivers/azure_blobs.py
 ##########
 @@ -299,8 +323,9 @@ def _xml_to_object(self, container, blob):
             extra['md5_hash'] = value
 
         meta_data = {}
-        for meta in list(metadata):
-            meta_data[meta.tag] = meta.text
+        if metadata:
+            for meta in list(metadata):
+                meta_data[meta.tag] = meta.text
 
 Review comment:
   same as above, is meta.tag guaranteed to be not None?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message