libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-1022) enhance digitalocean dns driver with ttl parameter
Date Sat, 10 Nov 2018 13:17:00 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682399#comment-16682399
] 

ASF GitHub Bot commented on LIBCLOUD-1022:
------------------------------------------

GitHub user kiniou opened a pull request:

    https://github.com/apache/libcloud/pull/1252

    [LIBCLOUD-1022] Enhance digitalocean dns driver with `ttl` parameter

    ## Enhance digitalocean dns driver with `ttl` parameter
    
    ### Description
    
    DigitalOcean provides a parameter to update dns records with `ttl` but the current driver's
code actually doesn't support it.
    
    For reference:
    
    - https://developers.digitalocean.com/documentation/v2/#update-a-domain-record
    - https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record
    
    ### Status
    
    ready for review
    
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiniou/libcloud LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1252
    
----
commit 57a80f94922eaa1fd8fa813414fac0e45613f80d
Author: Kevin Roy <kiniou@...>
Date:   2018-11-10T10:34:17Z

    add `ttl` parameters to digitalocean record operations

----


> enhance digitalocean dns driver with ttl parameter
> --------------------------------------------------
>
>                 Key: LIBCLOUD-1022
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-1022
>             Project: Libcloud
>          Issue Type: Bug
>          Components: DNS
>            Reporter: Kevin Roy
>            Priority: Minor
>
> DigitalOcean provides a parameters to update dns records with {{ttl}} parameter but
the current driver's code actually doesn't support it.
> For reference:
>  * [https://developers.digitalocean.com/documentation/v2/#update-a-domain-record]
>  * [https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message