libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fatmcgav <>
Subject [GitHub] libcloud pull request #1232: [LIBCLOUD-1007] Resolve RFC3339 date parsing is...
Date Mon, 20 Aug 2018 11:29:19 GMT
GitHub user fatmcgav opened a pull request:

    [LIBCLOUD-1007] Resolve RFC3339 date parsing issues with GCE Compute driver.

    Resolves issue with RFC3339 date parsing in the GCE Compute driver. 
    Timestamp strings are now parsed upto and including the microsecond value. 
    The call to deprecate the Google Compute image now also correctly formats the date as
RFC3339 format. 
    - done, ready for review
    - [ ] [Code linting](
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](
    - [ ] [ICLA](
(required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull gce_fix_rfc3339_parsing

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1232
commit d3ae06dcb95725db7d6474f193e182e3e4aa46fc
Author: Gavin Williams <fatmcgav@...>
Date:   2018-08-20T11:20:22Z

    [gce] Fix parsing of timestamp string.
    Now parses microseconds as part of strptime function, stopping at the '+' character to
denote a timezone offset.

commit 37a6d9adccbe0f6b1373708a4f7fcc14a38642b7
Author: Gavin Williams <fatmcgav@...>
Date:   2018-08-20T11:21:31Z

    [gce] Use return value from `timestamp_to_datetime` and correctly format
    the request datetime to RFC3339 format.



View raw message