libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rojopolis <...@git.apache.org>
Subject [GitHub] libcloud pull request #1222: [LIBCLOUD-1002] Instance template support for G...
Date Mon, 02 Jul 2018 23:35:54 GMT
GitHub user rojopolis opened a pull request:

    https://github.com/apache/libcloud/pull/1222

    [LIBCLOUD-1002] Instance template support for GCE create_node

    ## Instance template support for GCE create_node
    
    ### Allows Nodes to be created from GCE Instance Templates
    
    This change allows Nodes to be created from predefined Instance Templates in GCE.  
    This is useful in a number of scenarios:
    * Organizational standards are implemented with Templates.
    * etc.
    
    The attributes specified in the call to create_node will take precedence over those defined
in the template (per provider documentation).
    
    #### Provider docs: 
    - https://cloud.google.com/compute/docs/reference/rest/v1/instances/insert
    - https://cloud.google.com/compute/docs/instances/create-vm-from-instance-template
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rojopolis/libcloud LIBCLOUD-1002_gce_source_instance_template

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1222.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1222
    
----
commit ba1ce31771b8691af864d7e3585e0778ab685843
Author: Robert Jordan <robert@...>
Date:   2018-07-02T23:08:39Z

    [LIBCLOUD-1002] Add support for creating GCE instances from template

commit 8f64453561e9b3b8e7306223304f165b15595c7f
Author: Robert Jordan <rjordan@...>
Date:   2018-07-02T23:27:48Z

    [LIBCLOUD-1002] Add support for creating GCE instances from template

----


---

Mime
View raw message