From notifications-return-14576-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Tue May 22 16:21:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 90C85180638 for ; Tue, 22 May 2018 16:21:49 +0200 (CEST) Received: (qmail 79368 invoked by uid 500); 22 May 2018 14:21:48 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 79359 invoked by uid 99); 22 May 2018 14:21:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2018 14:21:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 574AEE0C5C; Tue, 22 May 2018 14:21:48 +0000 (UTC) From: vpyvovarov To: notifications@libcloud.apache.org Reply-To: notifications@libcloud.apache.org Message-ID: Subject: [GitHub] libcloud pull request #1213: SCALRCORE-8898. Add BigQuery client Content-Type: text/plain Date: Tue, 22 May 2018 14:21:48 +0000 (UTC) GitHub user vpyvovarov opened a pull request: https://github.com/apache/libcloud/pull/1213 SCALRCORE-8898. Add BigQuery client ## Add BigQuery client ### Description BQ client is required for implementing billing for GCE. After discussions were decided put this code under new category `extra`. This was done because BQ doesn't fit to any other (computer, storage DNS and etc). To not reinvent the weel we use existing lib from google. There are two client - one general client for BQ, second for getting billing data from BQ. I know that they are not following general code style of `libcloud`. `libcloud` was designed for providing a similar interface for all cloud providers. But BQ is a service that hardly has any analog from other cloud providers. So the main goal of putting this code under `libcloud`, is having one place for all client used at Scalr. ### Status ready for review ### Checklist (tick everything that applies) - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [ ] Documentation - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Scalr/libcloud feature/SCALRCORE-8898 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/1213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1213 ---- commit c15338622086a520f31f3d44f0b58551f406dc60 Author: Viktor Pyvovarov Date: 2018-05-22T14:03:09Z SCALRCORE-8898. Add BigQuery client commit 67b9d0974e820d88f8a21cf2385b8e1833f25fce Author: Viktor Pyvovarov Date: 2018-05-22T14:09:32Z SCALRCORE-8898. PEP8 ---- ---