libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ZuluPro <...@git.apache.org>
Subject [GitHub] libcloud pull request #1211: Added script to get automatically EC2 instance ...
Date Sun, 20 May 2018 03:32:50 GMT
GitHub user ZuluPro opened a pull request:

    https://github.com/apache/libcloud/pull/1211

    Added script to get automatically EC2 instance sizes

    Added script to get automatically EC2 instance sizes
    
    ### Description
    
    - I created a script to download & parse the big JSON from AWS
    This script outputs Python constants in the same format than in `ec2.py`
    I placed the output in libcloud/compute/constants.py (maybe bad?)
    - I cleaned `ec2.py` from the big dicts configuring sizes and region
    I import from constants and just add things not related to AWS (nimbus)
    - Updated tests
    Tests were too static, so I deleted some.
    
    ### Status
    
    Done
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ZuluPro/libcloud ec2_sizes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1211
    
----
commit c582ccc09135b9ae11b0d264ccafdbc0492201d2
Author: Anthony Monthe <anthony.monthe@...>
Date:   2018-05-20T03:23:14Z

    Added scrap'n'dump EC2 sizes script

commit a4a0f263a4952f3c3ba131b21d454d7e86c04023
Author: Anthony Monthe <anthony.monthe@...>
Date:   2018-05-20T03:24:10Z

    Cleaned EC2 files and added constants

commit 3582df6555b12aff3b3b4077ee6b822df96e1178
Author: Anthony Monthe <anthony.monthe@...>
Date:   2018-05-20T03:24:42Z

    Updated tests

----


---

Mime
View raw message