From notifications-return-14449-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Mon Mar 19 15:03:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 226F7180647 for ; Mon, 19 Mar 2018 15:03:05 +0100 (CET) Received: (qmail 88691 invoked by uid 500); 19 Mar 2018 14:03:05 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 88682 invoked by uid 99); 19 Mar 2018 14:03:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2018 14:03:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CE4A3C1FE5 for ; Mon, 19 Mar 2018 14:03:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 6Qmnj2ujDAKe for ; Mon, 19 Mar 2018 14:03:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E22715F659 for ; Mon, 19 Mar 2018 14:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7D243E0117 for ; Mon, 19 Mar 2018 14:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 367D72149D for ; Mon, 19 Mar 2018 14:03:00 +0000 (UTC) Date: Mon, 19 Mar 2018 14:03:00 +0000 (UTC) From: "Vincent Planchenault (JIRA)" To: notifications@libcloud.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (LIBCLOUD-989) Small bug in common/openstack.py MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Vincent Planchenault created LIBCLOUD-989: --------------------------------------------- Summary: Small bug in common/openstack.py Key: LIBCLOUD-989 URL: https://issues.apache.org/jira/browse/LIBCLOUD-989 Project: Libcloud Issue Type: Bug Components: Core Environment: Python 2.7 libcloud 2.3.0 Reporter: Vincent Planchenault Hello, I encountered a small bug in common/openstack.py, when an Openstack compati= ble french Cloud Provider wanted to tell me I've used its API at a too high= rate. In this case, the API returned a status 503, with a message composed of fie= lds 'message' and 'request', without 'code' field The code in line 393 in common/openstack.py raises in this case a TypeError= exception, because there is no 'code' field in the values. I changed this line from: =C2=A0=C2=A0=C2=A0 if len(values) > 0 and values[0]['code'] =3D=3D 404 and = key_pair_name: to: =C2=A0=C2=A0=C2=A0 if len(values) > 0 and 'code' in values[0] and values[0]= ['code'] =3D=3D 404 and key_pair_name: Now, it raises a libcloud.exception_from_message I=C2=A0 can handle properl= y. =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)