From notifications-return-14192-archive-asf-public=cust-asf.ponee.io@libcloud.apache.org Tue Jan 9 13:17:14 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 97EF2180718 for ; Tue, 9 Jan 2018 13:17:14 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 885AB160C2D; Tue, 9 Jan 2018 12:17:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CF9DB160C13 for ; Tue, 9 Jan 2018 13:17:13 +0100 (CET) Received: (qmail 49612 invoked by uid 500); 9 Jan 2018 12:17:13 -0000 Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@libcloud.apache.org Delivered-To: mailing list notifications@libcloud.apache.org Received: (qmail 49603 invoked by uid 99); 9 Jan 2018 12:17:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jan 2018 12:17:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E9F4EDFC32; Tue, 9 Jan 2018 12:17:12 +0000 (UTC) From: Rahul-CSI To: notifications@libcloud.apache.org Reply-To: notifications@libcloud.apache.org Message-ID: Subject: [GitHub] libcloud pull request #1162: [LIBCLOUD-973] Support disk_size parameter for ... Content-Type: text/plain Date: Tue, 9 Jan 2018 12:17:12 +0000 (UTC) GitHub user Rahul-CSI opened a pull request: https://github.com/apache/libcloud/pull/1162 [LIBCLOUD-973] Support disk_size parameter for boot disk when creating instance. ## Support specifying the disk size for boot disk when we create (one/more) google compute cloud instances. ### Description This is fix for LIBCLOUD-973 bug. Link to bug: https://issues.apache.org/jira/browse/LIBCLOUD-973 The ex_create_multiple_nodes API call in gce.py compute driver does not handle boot disk size. Hence it creates a boot disk of size 10GB every time. Added disk_size keyword parameter to ex_create_multiple_nodes API call, It passes the parameter through internal method calls and adds the disk size to the POST request. - API call sequence: 1. ex_create_multiple_nodes 2. _multi_create_node 3. _create_node_req 4. _create_instance_properties 5. _build_disk_gce_struct ### Status - done, ready for review ### Checklist (tick everything that applies) - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [X] Documentation - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cambridge-semantics/libcloud LIBCLOUD-973_Support_disk_size Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/1162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1162 ---- commit 81b58ae68bafde1156e445e3985e729871cb2666 Author: Rahul Paigavan Date: 2018-01-09T11:49:49Z [LIBCLOUD-973] Support disk_size parameter for boot disk while creating instances in ex_create_multiple_nodes API call. ---- ---