libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rahul-CSI <...@git.apache.org>
Subject [GitHub] libcloud pull request #1162: [LIBCLOUD-973] Support disk_size parameter for ...
Date Tue, 09 Jan 2018 12:17:12 GMT
GitHub user Rahul-CSI opened a pull request:

    https://github.com/apache/libcloud/pull/1162

    [LIBCLOUD-973] Support disk_size parameter for boot disk when creating instance.

    ## Support specifying the disk size for boot disk when we create (one/more) google compute
cloud instances.
    
    ### Description
    
    This is fix for LIBCLOUD-973 bug.
    Link to bug: https://issues.apache.org/jira/browse/LIBCLOUD-973
    The ex_create_multiple_nodes API call in gce.py compute driver
    does not handle boot disk size. Hence it creates a boot disk of size 10GB every time.
    Added disk_size keyword parameter to ex_create_multiple_nodes API call,
    It passes the parameter through internal method calls and adds the disk size to the POST
request.
    
    - API call sequence:
    1. ex_create_multiple_nodes
    2. _multi_create_node
    3. _create_node_req
    4. _create_instance_properties
    5. _build_disk_gce_struct
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [X] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cambridge-semantics/libcloud LIBCLOUD-973_Support_disk_size

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1162
    
----
commit 81b58ae68bafde1156e445e3985e729871cb2666
Author: Rahul Paigavan <rahul.paigavan@...>
Date:   2018-01-09T11:49:49Z

    [LIBCLOUD-973] Support disk_size parameter for boot disk while creating instances in ex_create_multiple_nodes
API call.

----


---

Mime
View raw message