libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zym-ustc <...@git.apache.org>
Subject [GitHub] libcloud pull request #1157: ECS Aliyun: support modify_security_group_attri...
Date Wed, 03 Jan 2018 06:54:23 GMT
GitHub user zym-ustc opened a pull request:

    https://github.com/apache/libcloud/pull/1157

    ECS Aliyun: support modify_security_group_attributes

    ## Aliyun ECS: Add support to modify attributes of security group
    
    ### Description
    
    - [describe_security_group_attributes.xml](https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/fixtures/ecs/describe_security_group_attributes.xml)
doesn't match its title.
    - Can't modify security group name or description via ECS driver currently
    
    Reference: 
    [Aliyun API Doc - DescribeSecurityGroupAttribute](https://help.aliyun.com/document_detail/25555.html?spm=5176.doc25556.6.893.9yP6oY)
    [Aliyun API Doc - ModifySecurityGroupAttribute](https://help.aliyun.com/document_detail/25559.html?spm=5176.doc25555.6.897.J4hUYN)
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
    
      

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zym-ustc/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1157
    
----
commit 94384a867026e8c9b02b60793fa8d6804d8299f5
Author: Zhang Yiming <zhangyiming215@...>
Date:   2018-01-03T02:20:46Z

    ECS Aliyun: support modify_security_group_attributes

----


---

Mime
View raw message