libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zym-ustc <>
Subject [GitHub] libcloud pull request #1157: ECS Aliyun: support modify_security_group_attri...
Date Wed, 03 Jan 2018 06:54:23 GMT
GitHub user zym-ustc opened a pull request:

    ECS Aliyun: support modify_security_group_attributes

    ## Aliyun ECS: Add support to modify attributes of security group
    ### Description
    - [describe_security_group_attributes.xml](
doesn't match its title.
    - Can't modify security group name or description via ECS driver currently
    [Aliyun API Doc - DescribeSecurityGroupAttribute](
    [Aliyun API Doc - ModifySecurityGroupAttribute](
    ### Status
    - done, ready for review
    ### Checklist (tick everything that applies)
    - [x] [Code linting](
(required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](
    - [ ] [ICLA](
(required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull trunk

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1157
commit 94384a867026e8c9b02b60793fa8d6804d8299f5
Author: Zhang Yiming <zhangyiming215@...>
Date:   2018-01-03T02:20:46Z

    ECS Aliyun: support modify_security_group_attributes



View raw message