libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-809) GCE deploy_node function should accept all the same parameters as create_node
Date Fri, 15 Dec 2017 05:52:00 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292066#comment-16292066
] 

ASF GitHub Bot commented on LIBCLOUD-809:
-----------------------------------------

GitHub user spyrdzy opened a pull request:

    https://github.com/apache/libcloud/pull/1155

    Fixes Apache LIBCLOUD-809

    ## Changes 
    Fixes Apache LIBCLOUD-809
    
    ### Description
    Merged variables and docstrings for deploy_node to meet features added to create_node.
    
    Reference link: https://issues.apache.org/jira/browse/LIBCLOUD-809
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [X] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/spyrdzy/libcloud 809

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1155
    
----
commit 69d76ec9ea5da2abdf973f2540cea4c3a3688a53
Author: Alexander Spyrdz <alxndr@alxndr-ubi.syd.corp.google.com>
Date:   2017-12-15T05:35:24Z

    deploy_node has variable parity with create_node.

commit addd61e56afdd8e7edb505813d6e353c2da49715
Author: Alexander Spyrdz <alxndr@google.com>
Date:   2017-12-15T05:48:40Z

    Docstring update

commit d00f90dee920517dfe84e975832e3002e696a6eb
Author: Alexander Spyrdz <alxndr@google.com>
Date:   2017-12-15T05:50:55Z

    Refix docstring

----


> GCE deploy_node function should accept all the same parameters as create_node
> -----------------------------------------------------------------------------
>
>                 Key: LIBCLOUD-809
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-809
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>            Reporter: Joshua Buss
>
> I can't figure out if deploy_node has been built the way it has for some reason, but
in my use case I'd like to use deploy_node because I have a script to run but I also want
to set the preemptive flag and external IP, which are available in create_node but not deploy_node
for some reason.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message