libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mlackman <...@git.apache.org>
Subject [GitHub] libcloud pull request #1124: [LIBCLOUD-952] Use disk size and storage tier a...
Date Fri, 06 Oct 2017 17:45:55 GMT
GitHub user mlackman opened a pull request:

    https://github.com/apache/libcloud/pull/1124

    [LIBCLOUD-952] Use disk size and storage tier also when creating node from template

    ## Add disk size and storage tier
    
    ### Description
    
    Added missing storage_tier and disk size to the request body for creating node. Storage_tier
has meaningful default value when not provided.  
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/UpCloudLtd/libcloud LIBCLOUD-952_UpCloud_driver_does_not_set_the_storage_size_and_storage_tier

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1124
    
----
commit e7e0869e7fbc174605f8d99172dd218685163d2a
Author: Mika Lackman <mika.lackman@upcloud.com>
Date:   2017-10-06T14:58:47Z

    Use disk size and storage tier also when creating node from template

----


---

Mime
View raw message