Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@libcloud.apache.org
Date: Wed, 20 Sep 2017 21:17:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: notifications@libcloud.apache.org
Message-ID: <JIRA.13091783.1501653135000.161019.1505942220089@Atlassian.JIRA>
In-Reply-To: <JIRA.13091783.1501653135000@Atlassian.JIRA>
References: <JIRA.13091783.1501653135000@Atlassian.JIRA> <JIRA.13091783.1501653135130@jira-lw-us.apache.org>
Subject: [jira] [Commented] (LIBCLOUD-934) Add support for GCE instance
 labels
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 20 Sep 2017 21:17:04 -0000


    [ https://issues.apache.org/jira/browse/LIBCLOUD-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173838#comment-16173838 ] 

ASF GitHub Bot commented on LIBCLOUD-934:
-----------------------------------------

GitHub user maxlip opened a pull request:

    https://github.com/apache/libcloud/pull/1115

    [LIBCLOUD-934] Adding support for GCE node labels.

    ## Changes Title [LIBCLOUD-934] Adding support for GCE node labels.
    
    ### Description
    
    Added the ability to set [resource labels](https://cloud.google.com/compute/docs/reference/latest/instances/setLabels
    ) for GCE VMs. This can be done on node/multinode creation or via new ex_set_node_labels method.
    
    There a few relevant JIRAs, such as https://issues.apache.org/jira/browse/LIBCLOUD-934
    
    For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
    section of our documentation.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [x ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maxlip/libcloud LIBCLOUD-934_gce-node-labels

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1115
    
----
commit 76848e98927d3261b03d8dcba3d1dfd8a2cab9d0
Author: maxlip <maxlip@gmail.com>
Date:   2017-09-20T21:09:18Z

    [LIBCLOUD-934] Adding support for GCE node labels.

----


> Add support for GCE instance labels
> -----------------------------------
>
>                 Key: LIBCLOUD-934
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-934
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.2.0
>         Environment: Ubuntu 17.04
>            Reporter: Hrish
>
> Output of pip freeze | grep libcloud
> apache-libcloud==2.0.0
> The version is actually 2.0.0 but I cannot see it in the dropdown.
> There is no support for fetching the labels for GCE instances - [https://cloud.google.com/compute/docs/labeling-resources]


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)