libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vongazman <...@git.apache.org>
Subject [GitHub] libcloud pull request #1107: [LIBCLOUD-944] Add support for private IP addre...
Date Thu, 07 Sep 2017 23:50:42 GMT
GitHub user vongazman opened a pull request:

    https://github.com/apache/libcloud/pull/1107

    [LIBCLOUD-944] Add support for private IP addresses in GCE instance creation

    ## Add support for private IP addresses in GCE instance creatio
    
    ### Description
    
    GCE driver doesn't currently allow private IPs to be specified when creating instances.
Updated gce.py driver to allow the optional parameter internal_ip which can be used when creating
GCE instances.  
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vongazman/libcloud LIBCLOUD-944_private_ip

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1107
    
----
commit 27d79ea671b1d502930719d00cacbd8337be3a8b
Author: Gareth Mcfarlane <gmcfarlane@gmcfarlane.syd.corp.google.com>
Date:   2017-09-07T10:53:08Z

    Add private IP functionality to GCE

----


---

Mime
View raw message