libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From micafer <...@git.apache.org>
Subject [GitHub] libcloud pull request #1074: Fix #LIBCLOUD-925
Date Tue, 20 Jun 2017 06:25:39 GMT
GitHub user micafer opened a pull request:

    https://github.com/apache/libcloud/pull/1074

    Fix #LIBCLOUD-925

    ## Fixex an error in _get_error function in GCE driver.
    
    ### Description
    Fixes an error in _get_error function in common/google.py file that assumes that the body['error']
value is a dict, but in some cases it contains an string (unicode).
    So it tries to do a err.get and it failts.
    
    ### Status
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/micafer/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1074.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1074
    
----
commit 814bc3e366bdce7f2b935eeb3c7ed21d562cf3e8
Author: micafer <micafer1@upv.es>
Date:   2017-06-20T06:21:37Z

    Fix #LIBCLOUD-925

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message