libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fjros <...@git.apache.org>
Subject [GitHub] libcloud pull request #1056: Fix list_sizes() for new regions in EC2 compute...
Date Tue, 09 May 2017 10:32:14 GMT
GitHub user fjros opened a pull request:

    https://github.com/apache/libcloud/pull/1056

    Fix list_sizes() for new regions in EC2 compute driver

    ## Fix list_sizes() for new regions in EC2 compute driver
    
    ### Description
    
    Calls to driver.list_sizes() were broken for new EC2 regions, namely 'eu-west-2', 'ca-central-1'
and 'cn-north-1'. There were two different problems:
    - The api name employed to scrape prices was incorrect in the case of 'eu-west-2' and
'ca-central-1'.
    - Pricing for the Beijing region doesn't seem to be available at the moment.
    
    This PR fixes these issues in the following way and closes #1045:
    1. Fix api names in `scrape-ec2-prices.py`
    2. Remove 'cn-north-1' from the VALID_EC2_REGIONS list
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fjros/libcloud fix-ec2-pricing-new-regions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1056.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1056
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message