libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pquentin <...@git.apache.org>
Subject [GitHub] libcloud pull request #1055: [LIBCLOUD-914] Fix raise in s3.upload_object_vi...
Date Fri, 05 May 2017 11:33:25 GMT
GitHub user pquentin opened a pull request:

    https://github.com/apache/libcloud/pull/1055

    [LIBCLOUD-914] Fix raise in s3.upload_object_via_stream

    ## [LIBCLOUD-914] Fix raise in s3.upload_object_via_stream
    
    ### Description
    
    Since libcloud 2.0, s3.upload_object_via_stream as used in Google Storage was raising
a generic
    libcloud.common.types.LibcloudError on all exceptions, but we now raise
    the correct exception. This also removes a comment that is probably
    outdated.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pquentin/libcloud patch-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1055
    
----
commit 8e10044947669491fbd765ba4507e7d4d866f110
Author: Quentin Pradet <quentin@clustree.com>
Date:   2017-05-05T11:21:43Z

    [LIBCLOUD-914] Fix raise in s3.upload_object_via_stream
    
    Since libcloud 2.0, it was raising a generic
    libcloud.common.types.LibcloudError on all exceptions, but we now raise
    the correct exception. This also removes a comment that is probably
    outdated.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message