libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SElsharkawy <...@git.apache.org>
Subject [GitHub] libcloud pull request #1051: Fix checking for None location in few functions
Date Tue, 02 May 2017 16:07:33 GMT
GitHub user SElsharkawy opened a pull request:

    https://github.com/apache/libcloud/pull/1051

    Fix checking for None location in few functions

    This suggested update fixes the condition that checks for parameter "location" being None.
If the parameter is not None, the original code would still exit and raise ValueError exception.
    
    ## Changes Title (replace this with a logical title for your changes)
    
    ### Description
    
    Replace this with the PR description (mention the changes you have made, why
    you have made them, provide some background and any references to the provider
    documentation if needed, etc.).
    
    For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
    section of our documentation.
    
    ### Status
    
    Replace this: describe the PR status. Examples:
    
    - work in progress
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SElsharkawy/libcloud patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1051.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1051
    
----
commit 625e7d11f6ca9ef3e22170bdc6e18275e603acb1
Author: SElsharkawy <elsharkawy@nilogix.com>
Date:   2017-05-02T16:02:29Z

    Fix checking for None location in few functions
    
    This suggested update fixes the condition that checks for parameter "location" being None.
If the parameter is not None, the original code would still exit and raise ValueError exception.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message