libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fjros <...@git.apache.org>
Subject [GitHub] libcloud pull request #1045: Add test to check that can list sizes for all v...
Date Wed, 26 Apr 2017 14:20:58 GMT
GitHub user fjros opened a pull request:

    https://github.com/apache/libcloud/pull/1045

    Add test to check that can list sizes for all valid ec2 regions

    ## Add test to check that can list sizes for all valid ec2 regions
    
    ### Description
    
    EC2 compute driver fails to list sizes in some regions. The reason is that pricing hasn't
been updated in such cases.
    
    This PR adds a test to force the build fail if not all supported regions are working properly.
I'd like to start a discussion about how to avoid this failure from happening again in the
future (what about scraping prices as part of the build process?).
    
    ### Status
    
    - start discussion
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fjros/libcloud test-ec2-pricing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1045.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1045
    
----
commit 4975c03c2826ee389c8cd86f2ff364d11c30ad08
Author: Francisco Ros <fjros@doalitic.com>
Date:   2017-04-26T14:06:41Z

    Add test to check that can list sizes for all valid ec2 regions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message