libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tonybaloney <...@git.apache.org>
Subject [GitHub] libcloud pull request #1039: Make the choice between LXML and etree a packag...
Date Mon, 24 Apr 2017 01:06:44 GMT
GitHub user tonybaloney opened a pull request:

    https://github.com/apache/libcloud/pull/1039

    Make the choice between LXML and etree a package level switch

    LXML is not strictly compatible with etree, although it claims to be.
    
    This change introduces a package-level import for ET (either LXML or etree) and allows
the user to force the use of LXML but it defaults to false.
    
    If you have LXML in your global packages, it will default to LXML at the moment and a
number of drivers simply don't work with LXML


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tonybaloney/libcloud lxml_toggle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1039.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1039
    
----
commit 9abe5ca9bbc3323bb14ca9c45f8ac9dc51e34f27
Author: Anthony Shaw <anthonyshaw@apache.org>
Date:   2017-04-24T01:02:31Z

    make ET/LXML a toggle instead of trying to import. Effectively makes LXML non-default

commit 4229ddf5478c8b6da6603f1f2486ddb000cbee81
Author: Anthony Shaw <anthonyshaw@apache.org>
Date:   2017-04-24T01:04:56Z

    fix linting issue in secrets template

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message