libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tonybaloney <...@git.apache.org>
Subject [GitHub] libcloud pull request #1026: Fix Linode for 2.0x
Date Thu, 06 Apr 2017 02:03:09 GMT
GitHub user tonybaloney opened a pull request:

    https://github.com/apache/libcloud/pull/1026

    Fix Linode for 2.0x 

    Changes in #1025 highlighted a problem with the Linode response class.
    
    It has a lot of copy+paste from the Response `__init__` and no call to super. This looks
related to some legacy code but its a common anti-pattern.
    
    https://github.com/apache/libcloud/commit/fe72fc13a131b446e1f18cd22005f9c8fd03ce79
    
    This changeset removes the duplicate (but now broken) code and calls `super` correctly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tonybaloney/libcloud linode_problems

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1026.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1026
    
----
commit af5b3b8044eeff10ef119db5a3852d171aedc2bd
Author: Anthony Shaw <anthonyshaw@apache.org>
Date:   2017-04-06T01:58:35Z

    remove weird __init__ code from the linode response class, use super

commit 2ed37b31588a769f6fa15bc8b9b3c694522a0e9a
Author: Anthony Shaw <anthonyshaw@apache.org>
Date:   2017-04-06T02:01:03Z

    remove unused imports

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message