libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tonybaloney <>
Subject [GitHub] libcloud pull request #972: Fix secure propagation to connection class
Date Tue, 10 Jan 2017 01:51:08 GMT
GitHub user tonybaloney opened a pull request:

    Fix secure propagation to connection class

    Since there is no longer a secure/insecure connection class, they are one and the same.
    This change adds new tests to check that
    - When a connection is defined as secure, the connection class will use the https scheme.
    - When a connection scheme implies a port, the port is not included in the URL
    - When a connection defines secure and an unusual port, the scheme is propagated
    It uncovered 1 issue with secure connections not being explicit for unusual ports.

You can merge this pull request into a Git repository by running:

    $ git pull fix_secure_propagation

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #972
commit 2f85baaffca0221bad9442a531e05acfed2ce887
Author: Anthony Shaw <>
Date:   2017-01-10T01:18:39Z

    test to prove it's currently broken

commit 1e5945f8b04a1d123a89c87e855b7e38fcb45a1a
Author: Anthony Shaw <>
Date:   2017-01-10T01:43:45Z

    fix secure propagation issue

commit 72f1e19b7bf6f8bbe1cac504d5eb2da19808edb7
Author: Anthony Shaw <>
Date:   2017-01-10T01:48:59Z

    more tests for insecure and secure connections


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message