libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From charly37 <...@git.apache.org>
Subject [GitHub] libcloud pull request #952: [LIBCLOUD-879] Add support of node without publi...
Date Wed, 23 Nov 2016 01:52:30 GMT
GitHub user charly37 opened a pull request:

    https://github.com/apache/libcloud/pull/952

    [LIBCLOUD-879] Add support of node without public IP in LB

    ## Add support of Node without public IP in GCP load balancer
    
    ### Description
    
    Link to jira ticket 879 
    https://issues.apache.org/jira/browse/LIBCLOUD-879
    
    I had a condition to only try to grab the publicIP of a node if it had one since publicIP
is not mandatory.
    
    ### Status
    
    This PR is ready to be review. I run the test (tox) before and after the change and no
impact.
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting] I tried to followed the guidline
    - [X] [Documentation] No change require
    - [X] [Tests] No impact on existing test (but no time to had more)
    - [X] [ICLA] Minor change so I skip it
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charly37/libcloud 879_PublicIpOpt

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/952.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #952
    
----
commit 38ae70157de7176e486b9c9965e9d9f385de3221
Author: Charles Walker <charles.walker.37@gmail.com>
Date:   2016-11-23T01:34:05Z

    [LIBCLOUD-879] Add support of node without public IP in LB

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message