libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smgoller <...@git.apache.org>
Subject [GitHub] libcloud pull request #925: [LIBCLOUD-867] Add st1 and sc1 volume types to v...
Date Thu, 27 Oct 2016 19:02:43 GMT
GitHub user smgoller opened a pull request:

    https://github.com/apache/libcloud/pull/925

    [LIBCLOUD-867] Add st1 and sc1 volume types to valid types

    ## Add additional supported storage types to create_volume
    
    ### Description
    
    EC2 supports additional storage types geared toward throughput and cold storage. We have
a need for the cold storage volume type but libcloud currently doesn't support it. It seemed
a good idea to just put up a pull request for this instead of asking for the change since
it's so small.
    
    We didn't feel there was a need to create a test for this change, nor additional documentation
examples. If this is not the case we can add them.
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [*] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smgoller/libcloud LIBCLOUD-867

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/925.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #925
    
----
commit 9fd9dbd5a519b6eb476e593b525ee86e7f79213e
Author: Sean Goller <sean@goller.net>
Date:   2016-10-27T18:48:53Z

    [LIBCLOUD-867] Add st1 and sc1 volume types to valid types

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message