libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samuelchong <...@git.apache.org>
Subject [GitHub] libcloud pull request #902: Refactor DimensionData Create node to support MC...
Date Thu, 13 Oct 2016 00:46:55 GMT
GitHub user samuelchong opened a pull request:

    https://github.com/apache/libcloud/pull/902

    Refactor DimensionData Create node to support MCP2 and backward compatible with MCP1

    ## Changes Title (replace this with a logical title for your changes)
    
    ### Description
    Refactor create_node for MCP2 to support CaaS API 2.3 feature. You could now specify Network
Adapter Name for primary and additional NIC. Parameters in create_node function is tailored
for MCP2.  
    
    However, this function also allow backward compatibility for MCP1 using kwargs. Code snippet
provided in documentation on creating node for MCP1 and MCP2. 
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [X] Documentation
    - [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/samuelchong/libcloud create_node_mcp2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/902.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #902
    
----
commit 95d1001592013af05198e76ce5f6cc1a3960515e
Author: Samuel Chong <samuelchong1@gmail.com>
Date:   2016-10-11T00:47:55Z

    update create_node function for  MCP2 and implement backward compatibility for MCP1 using
kwarg

commit 278c6355623f664ccf9ae9c9bd9b64a1df716753
Author: Samuel Chong <samuelchong1@gmail.com>
Date:   2016-10-11T01:00:46Z

    Remove unnecessary comment

commit 81829b47cd61eb0050ebb15ef49391c3101384ae
Author: Samuel Chong <samuelchong1@gmail.com>
Date:   2016-10-13T00:09:36Z

    Merge remote-tracking branch 'apache/trunk' into create_node_mcp2

commit fc9c3960c173f3ed7fcabcac1e7b0c6d5ffed6cd
Author: Samuel Chong <samuelchong1@gmail.com>
Date:   2016-10-13T00:37:42Z

    Fix lint error

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message