libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From femnad <...@git.apache.org>
Subject [GitHub] libcloud pull request #894: LIBCLOUD-858: Fix Listing Libvirt Nodes with Pyt...
Date Sun, 09 Oct 2016 06:25:22 GMT
GitHub user femnad opened a pull request:

    https://github.com/apache/libcloud/pull/894

    LIBCLOUD-858: Fix Listing Libvirt Nodes with Python 3

    ## Fix Listing Libvirt Nodes with Python 3
    
    ### Description
    
    Listing nodes with the `Libvirt` provider fails on Python 3 because of a `split` operation
on a `bytes` object where the delimiter is not a `bytes` object.
    
    Use the `ensure_string` function from the `py3` module to ensure that the output of a
`subprocess.Popen` call is always a string for Python 2 and 3. Also add a test to convert
the mock command output results to `bytes` objects if the active Python version is 3.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/femnad/libcloud LIBCLOUD-858_fix-libvirt-node-listing-with-python-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #894
    
----
commit 9c01bf6eb970eb3ba315d135ffd6fb5ee7b45b7e
Author: Fahri Cihan Demirci <femnad@users.noreply.github.com>
Date:   2016-10-09T06:15:10Z

    LIBCLOUD-858: Fix Listing Libvirt Nodes with Python 3

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message