libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wrigri <...@git.apache.org>
Subject [GitHub] libcloud pull request: Fix gce_demo for loadbalancing and Python 3
Date Mon, 25 Apr 2016 17:34:56 GMT
GitHub user wrigri opened a pull request:

    https://github.com/apache/libcloud/pull/776

    Fix gce_demo for loadbalancing and Python 3

    ## Fix gce_demo.py for load balancing and Python 3
    
    ### Description
    
    Firewall for load balancing needs target tags set instead of source tags.
    The 'print' statement was causing this code to not run in Python 3.x.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [NA] Documentation
    - [NA] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [X] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wrigri/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/776.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #776
    
----
commit 99b8ec59c5b279c0eee42e2ef0910620219a7d79
Author: Rick Wright <rickw@google.com>
Date:   2016-04-25T17:24:25Z

    Fix gce_demo for loadbalancing and Python 3
    
    The firewall for loadbalancing needs to have "target tags" set instead
    of "source tags" and the print statement fails on Python 3.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message