libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pzrq <...@git.apache.org>
Subject [GitHub] libcloud pull request: Fix most Python 2 lxml tests
Date Fri, 22 Apr 2016 13:55:19 GMT
GitHub user pzrq opened a pull request:

    https://github.com/apache/libcloud/pull/772

    Fix most Python 2 lxml tests

    ## Fix libcloud + lxml tests under Python 2.x (ex. vcloud)
    
    ### Description
    
    Travis will hopefully confirm this improves the Python 2.x lxml tests from:
    `FAILED (failures=1, errors=52, skipped=14)`
    To:
    `FAILED (failures=1, errors=9, skipped=14)`
    
    I spent an hour trying to understand VCloud's XML builder but it's just a bit complicated
for me at this time, which is all that's left to fix under Python 2.7 for me at least. If
I can make time to figure it out I'll create another PR.
    
    #### Context
    Hopefully #769 gets a better chance of going through or getting some feedback so Mathspace
isn't forced to switch to boto3, this being our third cloud provider in the last year (long
story) which theoretically at least makes sticking with libcloud very attractive as long as
we can get it working under Python 3, preferably without forking it.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mathspace/libcloud py2-lxml

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/772.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #772
    
----
commit c8761e6a257a999aef2b5e117bd82e6689d3e877
Author: Peter Schmidt <peter@peterjs.com>
Date:   2016-04-22T12:00:44Z

    abiquo.py: Apply lxml ElementTree import pattern properly

commit fe7c5ee2da5461d7570363efd4221c6fbdc6cce0
Author: Peter Schmidt <peter@peterjs.com>
Date:   2016-04-22T12:45:31Z

    azure_blobs.py: Apply lxml ElementTree import pattern properly

commit 0f322dfa4e4dd5b2a0e991cc4778d2d1e5a9088c
Author: Peter Schmidt <peter@peterjs.com>
Date:   2016-04-22T13:11:53Z

    profitbricks.py: Figure out a pattern that works with xml + lxml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message