libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kami <...@git.apache.org>
Subject [GitHub] libcloud pull request: Fix regression with "_ex_connection_class_k...
Date Fri, 15 Apr 2016 19:15:34 GMT
GitHub user Kami opened a pull request:

    https://github.com/apache/libcloud/pull/755

    Fix regression with "_ex_connection_class_kwargs" kwargs getting overridden with None
in the BaseDriver class

    This issue was originally reported by Jay Rolette on the mailing list.
    
    fe81fef807d0f26b0fe94d55aa59b6979d133ae8 introduced a regression where arguments such
as `timeout`, etc. supplied via `_ex_connection_class_kwargs` method would get overridden
with `None` if the values for those arguments weren't explicitly passed to the driver constructor.
    
    This pull request fixes that and adds some test cases to make sure we don't introduce
the same regression or break it again in the future.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/libcloud ex_connection_class_kwargs_regression_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/755.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #755
    
----
commit 3ccd2e71b314ba63c3df9f43635c92d996b5fed8
Author: Tomaz Muraus <tomaz@tomaz.me>
Date:   2016-04-15T19:02:24Z

    Add failing regression test case for timeout argument preservation on the
    BaseDriver class.

commit fd0a22feab0e473591103020487fbbde33e973af
Author: Tomaz Muraus <tomaz@tomaz.me>
Date:   2016-04-15T19:09:15Z

    Fix a bug with timeout BaseDriver argument provided via
    "_ex_connection_class_kwargs" getting accidentaly overriden with
    None.
    
    Also add additional test cases.
    
    This issue was originally reported by Jay Rolette on the mailing list.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message