libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From schaubl <...@git.apache.org>
Subject [GitHub] libcloud pull request: Fix OpenStack IP type resolution
Date Wed, 06 Apr 2016 13:58:33 GMT
GitHub user schaubl opened a pull request:

    https://github.com/apache/libcloud/pull/738

    Fix OpenStack IP type resolution

    Checking the type of the IP with `explicit_ip_type` is not reliable.
    A fixed IP is not always a private IP and a floating IP is not always a public one.
    
    So I moved up the check of the public subnets.
    
    I also added the `addresses` element of the reply in the `extra` dict.
    This allows users to implement their own algorithm to find the right IP (e.g. by network
name).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/schaubl/libcloud openstack-fix_ip_type_resolution

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #738
    
----
commit 59c322fe9a874bb08cc7bc0add2cc7d2bd0b2e61
Author: lionel <lionel@sixsq.com>
Date:   2016-04-06T12:50:01Z

    Fix OpenStack IP type resolution

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message