libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From to...@apache.org
Subject [03/11] libcloud git commit: Update with new param name for consistency Closes #752
Date Sat, 16 Apr 2016 17:39:44 GMT
Update with new param name for consistency
Closes #752


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/308e1a2d
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/308e1a2d
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/308e1a2d

Branch: refs/heads/ex_connection_class_kwargs_regression_fix
Commit: 308e1a2d35dc3e4aac17536ff4dd22dde5ae6bb8
Parents: 32e9f99
Author: anthony-shaw <anthonyshaw@apache.org>
Authored: Sat Apr 16 15:29:07 2016 +1000
Committer: anthony-shaw <anthonyshaw@apache.org>
Committed: Sat Apr 16 15:35:24 2016 +1000

----------------------------------------------------------------------
 libcloud/compute/drivers/dimensiondata.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/libcloud/blob/308e1a2d/libcloud/compute/drivers/dimensiondata.py
----------------------------------------------------------------------
diff --git a/libcloud/compute/drivers/dimensiondata.py b/libcloud/compute/drivers/dimensiondata.py
index 1b9695f..f74770b 100644
--- a/libcloud/compute/drivers/dimensiondata.py
+++ b/libcloud/compute/drivers/dimensiondata.py
@@ -1708,20 +1708,20 @@ class DimensionDataNodeDriver(NodeDriver):
         response_code = findtext(result, 'responseCode', TYPES_URN)
         return response_code in ['IN_PROGRESS', 'OK']
 
-    def ex_remove_storage_from_node(self, node, disk_id):
+    def ex_remove_storage_from_node(self, node, scsi_id):
         """
         Remove storage from a node
 
         :param  node: The server to add storage to
         :type   node: :class:`Node`
 
-        :param  disk_id: The ID of the disk to remove
-        :type   disk_id: ``str``
+        :param  scsi_id: The ID of the disk to remove
+        :type   scsi_id: ``str``
 
         :rtype: ``bool``
         """
         disk = [disk for disk in node.extra['disks']
-                if disk.scsi_id == disk_id][0]
+                if disk.scsi_id == scsi_id][0]
         return self.ex_remove_storage(disk.id)
 
     def ex_remove_storage(self, disk_id):
@@ -1736,13 +1736,13 @@ class DimensionDataNodeDriver(NodeDriver):
 
         :rtype: ``bool``
         """
-        update_node = ET.Element('removeDisk',
+        remove_disk = ET.Element('removeDisk',
                                  {'xmlns': TYPES_URN})
-        update_node.set('id', disk_id)
+        remove_disk.set('id', disk_id)
         result = self.connection.request_with_orgId_api_2(
             'server/removeDisk',
             method='POST',
-            data=ET.tostring(update_node)).object
+            data=ET.tostring(remove_disk)).object
         response_code = findtext(result, 'responseCode', TYPES_URN)
         return response_code in ['IN_PROGRESS', 'OK']
 


Mime
View raw message