libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jimbobhickville <...@git.apache.org>
Subject [GitHub] libcloud pull request: Use hasattr rather than getattr to check fo...
Date Tue, 15 Dec 2015 16:45:57 GMT
GitHub user jimbobhickville opened a pull request:

    https://github.com/apache/libcloud/pull/659

    Use hasattr rather than getattr to check for existence

    I forgot getattr throws an exception.  This should have
    been a hasattr.  Additionally added a check to make sure
    it's a dict before treating it as such.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jimbobhickville/libcloud bad-attr-check

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #659
    
----
commit 03fb4c44c0fd504beb61896c8fec0778195c1f46
Author: Greg Hill <greg.hill@rackspace.com>
Date:   2015-12-15T16:42:47Z

    Use hasattr rather than getattr to check for existence
    
    I forgot getattr throws an exception.  This should have
    been a hasattr.  Additionally added a check to make sure
    it's a dict before treating it as such.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message