libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lakshmi-kannan <...@git.apache.org>
Subject [GitHub] libcloud pull request: Fix a bug in consuming streams in Paramiko ...
Date Sun, 02 Aug 2015 22:12:11 GMT
GitHub user lakshmi-kannan opened a pull request:

    https://github.com/apache/libcloud/pull/558

    Fix a bug in consuming streams in Paramiko ssh client 

    I wrote a wrapper to that wraps the SSH client to test. See https://github.com/lakshmi-kannan/st2/pull/2
and specifically https://github.com/lakshmi-kannan/st2/commit/1f0e025f8ff378eff7dd00a929cffce035e63a4b.
    
    ```
    (virtualenv)/m/s/s/st2 git:paramiko_parallel_ssh ❯❯❯ st2common/bin/paramiko_ssh_evenlets_tester.py
--hosts=localhost,127.0.0.1 --user=lakshmi --private-key="/home/vagrant/.ssh/id_rsa" --cmd="pwd"
    "cmd results: \n{'127.0.0.1': [u'/home/lakshmi\\n', '', 0, True], 'localhost': [u'/home/lakshmi\\n',
'', 0, True]}"
    (virtualenv)/m/s/s/st2 git:paramiko_parallel_ssh ❯❯❯
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lakshmi-kannan/libcloud paramiko_ssh_client_consume_streams_bug_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #558
    
----
commit e5e71e1e7fea1d9392a29628b67aa39c80bd4562
Author: Lakshmi Kannan <lakshmi+github@lakshmikannan.me>
Date:   2015-08-02T21:54:09Z

    Consume stdout, stderr streams on exit_status_ready
    
    * In some cases such as executing commands on localhost
    via SSH, exit_status_ready gets set super fast. We don't
    seem to consume them if this happens. The problem
    manifest when you wrap the ParamikoSSHClient inside
    something like an evenlet pool. This PR fixes that issue.

commit 5462886f7f408f285a355dfa24d8c42c5b067c7f
Author: Lakshmi Kannan <lakshmi+github@lakshmikannan.me>
Date:   2015-08-02T22:08:23Z

    Update CHANGES.rst

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message