libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcastillo2nd <...@git.apache.org>
Subject [GitHub] libcloud pull request: DNS driver for digitalocean and other minor...
Date Tue, 14 Apr 2015 03:34:15 GMT
GitHub user jcastillo2nd opened a pull request:

    https://github.com/apache/libcloud/pull/505

    DNS driver for digitalocean and other minor Node driver updates

    - This includes common.digitalocean with the Node driver using the DigitalOceanBaseDriver
    - DigitalOceanBaseDriver ( and NodeDriver ) will handle v1 and v2 credentials properly
    - DigitalOceanNodeDriver ( for v1 ) implements ( 4 of the ) KeyPair Management instead
of using ex_ssh_*
    - DigitalOceanDNSDriver implemented, only with v2 credentials, as v1 will at some point
be deprecated so it was not implemented
    - DigitalOceanDNSDriver tests have been created
    - Modified FixtureRoots to include common so that tests for common could use it
    
    I'v run through the DigitalOcean files ( for common, node and dns ) with flake8, and with
the exception of 2 tests files, ( with long strings that I don't know how to break up to pass
the test AND land within 79 chars ) everything is clean.
    
    I would like to note that the documentation on the KeyPair management may need to be updated
to include return types that are consistent with the other components of libcloud. This could
be setup in an issue, but at the same time, this could be arbitrarily added without breaking
anything before accepting this merge.
    
    - KeyPair include a delete(self) function that calls driver.delete_key_pair(self)
    - create_key_pair()  comment setup a rtype of KeyPair to make explicit that create_key_pair()
returns a KeyPair instance ( like create_node returns a Node )

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcastillo2nd/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #505
    
----
commit 13e1a2cea1f9cbde8bdbb9f09124813f6b2c4f22
Author: Javier Castillo II <jcastillo2nd@libcloud.castlecorporation.com>
Date:   2015-04-11T01:26:18Z

    DigitalOceanDNSDriver implementation.
    
    Pulled connection/response from libcloud.compute.driver.digitalocean into libcloud.common.digitalocean
    Implemented majority functions in libcloud.dns.driver.digitalocean

commit 98a57c2ad3cd108fee41062e50c7616b597a8204
Author: Javier Castillo II <j.castillo.2nd@gmail.com>
Date:   2015-04-11T02:30:35Z

    Implemented libcloud.dns.driver.digitalocean DigitalOceanDNSDriver.update_record

commit 153148d38c0a95a87aa6501895da4f9ac5025312
Author: Javier Castillo II <j.castillo.2nd@gmail.com>
Date:   2015-04-12T01:57:29Z

    Added unit tests and common/DigitalOceanBaseDriver
    - Added 'common' to FIXTURES_ROOT for FileFixtures in test/common
    - Modified DigitalOceanBaseDriver from compute/drivers/digitalocean into common/digitalocean
to support v1 and v2 by initialization
    - Added dns/driver/digitalocean tests
    - Added common/digitalocean tests

commit 458fcf81b4ac5c03e845efb572a233eb2976c57e
Author: Javier Castillo II <j.castillo.2nd@gmail.com>
Date:   2015-04-12T02:06:32Z

    Cleaned up some unused imports in tests, as well as removed redundant tests from dns/test_digitalocean
performed in DigitalOceanBaseDriver

commit dbf57b0d3a55460d98d82b4256628cf7492af03c
Author: Javier Castillo II <j.castillo.2nd@gmail.com>
Date:   2015-04-12T18:02:07Z

    DO NodeDriver uses DO BaseDriver
    - Support for v1 and v2 initialization with authentication secret
    - Updated v1 DigitalOceanNodeDriver to use updated KeyPair Management
    - Updated tests to reflect KeyPair Management changes

commit 35974f5de83a01e91260fc76277739143b1e89e5
Author: Javier Castillo II <j.castillo.2nd@gmail.com>
Date:   2015-04-12T20:31:02Z

    Cosmetic clean up

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message