libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fifieldt <...@git.apache.org>
Subject [GitHub] libcloud pull request: Fix bug LIBCLOUD-635 - openstack-swift auth...
Date Wed, 01 Apr 2015 02:12:23 GMT
GitHub user fifieldt opened a pull request:

    https://github.com/apache/libcloud/pull/492

    Fix bug LIBCLOUD-635 - openstack-swift auth v2

    As reported by James in LIBCLOUD-635
    https://issues.apache.org/jira/browse/LIBCLOUD-635
    
    OpenStack-Swift authentication is broken from at least
     0.16. I confirmed the bug in 0.17 and master.
    
    the code here tries to perform operations on a
    OpenStackServiceCatalogEntryEndpoint that cannot
    be performed on this class.
    
    Since get_endpoint() will return an endpoint with
    a URL (not 3 different URLs: publicURL/internalURL/
    adminURL) or error, it should be safe to test for
    existence and use the url. However, review very
    welcome!
    
    This fix has been tested against OpenStack Juno.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fifieldt/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #492
    
----
commit ec58868c3344a9bfe7a0166fc31c0548ed22ea87
Author: Tom Fifield <tom@openstack.org>
Date:   2015-04-01T02:05:36Z

    Fix bug LIBCLOUD-635 - openstack-swift auth v2
    
    As reported by James in LIBCLOUD-635
    https://issues.apache.org/jira/browse/LIBCLOUD-635
    
    OpenStack-Swift authentication is broken from at least
     0.16. I confirmed the bug in 0.17 and master.
    
    the code here tries to perform operations on a
    OpenStackServiceCatalogEntryEndpoint that cannot
    be performed on this class.
    
    Since get_endpoint() will return an endpoint with
    a URL (not 3 different URLs: publicURL/internalURL/
    adminURL) or error, it should be safe to test for
    existence and use the url. However, review very
    welcome!
    
    This fix has been tested against OpenStack Juno.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message