libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erjohnso <...@git.apache.org>
Subject [GitHub] libcloud pull request: [google compute] raise notfound on images t...
Date Wed, 28 Jan 2015 23:58:44 GMT
GitHub user erjohnso opened a pull request:

    https://github.com/apache/libcloud/pull/441

    [google compute] raise notfound on images that are not found

    If a user tried to delete an image by name (string) and the image was not found, the code
would fail with a `NoneType` does not contain `name` attribute error.
    
    This fixes the case where if an image can't be found by string name, it will raise a `ResourceNotFoundError`.
    
    /cc @tanpeter - if you think this will work and is good, I can merge it in.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/erjohnso/libcloud gce_image_del

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #441
    
----
commit 428884c6260407e8d4adfee0e745f4faea473079
Author: Eric Johnson <erjohnso@google.com>
Date:   2015-01-28T23:55:23Z

    [google compute] raise notfound on images that are not found

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message