Mailing-List: contact notifications-help@libcloud.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@libcloud.apache.org
From: erjohnso <git@git.apache.org>
To: notifications@libcloud.apache.org
Reply-To: notifications@libcloud.apache.org
Message-ID: <git-pr-419-libcloud@git.apache.org>
Subject: [GitHub] libcloud pull request: [google compute] Add missing
 attributes/met...
Content-Type: text/plain
Date: Thu, 18 Dec 2014 22:45:15 +0000 (UTC)

GitHub user erjohnso opened a pull request:

    https://github.com/apache/libcloud/pull/419

    [google compute] Add missing attributes/methods to create_node()

    @Kami, @runseb - I would appreciate a review of this one.  This PR has the potential to break GCE users, but the `demos/gce_demo.py` and tox tests are all good, so I think it's in good shape.
    
    Improvements to Node.  Adding missing attributes and methods to make it match the GCE API.
    * Added Node attributes such as `canIpForward`, `serviceAccounts`, etc to `node['extra']`.
    * Added `ex_add_access_config()`
    * Added `ex_delete_access_config()`
    * Added `ex_set_node_metadata()`
    * Added `ex_get_serial_output()`
    
    The newly added attributes and methods docs are covered at https://cloud.google.com/compute/docs/reference/latest/instances

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/erjohnso/libcloud GCE_Instances

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/419.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #419
    
----
commit d2fec9ebb607eb2c76e542a4fd34cc777346cd34
Author: Eric Johnson <erjohnso@google.com>
Date:   2014-12-15T21:21:45Z

    [google compute] Add missing attributes/methods to create_node()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---