libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erjoh...@apache.org
Subject libcloud git commit: Revert "[LIBCLOUD-610] gce: better error message for missing key file"
Date Wed, 31 Dec 2014 23:33:25 GMT
Repository: libcloud
Updated Branches:
  refs/heads/trunk b328757ab -> 5f0ccc1a5


Revert "[LIBCLOUD-610] gce: better error message for missing key file"

This reverts commit 95ae5beea125797ba3bd07028af1dbbd65dc2265.

Signed-off-by: Eric Johnson <erjohnso@google.com>


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/5f0ccc1a
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/5f0ccc1a
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/5f0ccc1a

Branch: refs/heads/trunk
Commit: 5f0ccc1a5c3efb1a76e9e414e9691a17ba7f40a9
Parents: b328757
Author: Eric Johnson <erjohnso@google.com>
Authored: Wed Dec 31 23:32:57 2014 +0000
Committer: Eric Johnson <erjohnso@google.com>
Committed: Wed Dec 31 23:32:57 2014 +0000

----------------------------------------------------------------------
 CHANGES.rst               | 4 ----
 libcloud/common/google.py | 3 ---
 2 files changed, 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/libcloud/blob/5f0ccc1a/CHANGES.rst
----------------------------------------------------------------------
diff --git a/CHANGES.rst b/CHANGES.rst
index 215b0d4..47a1ab6 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -16,10 +16,6 @@ General
 Compute
 ~~~~~~~
 
-- GCE improved error checking / message if missing API PEM file.
-  (LIBCLOUD-610, GITHUB-424)
-  [Eric Johnson]
-
 - GCE Licenses added to the GCE driver.
   (GITHUB-420)
   [Eric Johnson]

http://git-wip-us.apache.org/repos/asf/libcloud/blob/5f0ccc1a/libcloud/common/google.py
----------------------------------------------------------------------
diff --git a/libcloud/common/google.py b/libcloud/common/google.py
index 5069016..ebb9fdf 100644
--- a/libcloud/common/google.py
+++ b/libcloud/common/google.py
@@ -488,9 +488,6 @@ class GoogleServiceAcctAuthConnection(GoogleBaseAuthConnection):
         # The message contains both the header and claim set
         message = '%s.%s' % (header_enc, claim_set_enc)
         # Then the message is signed using the key supplied
-        if not os.access(self.key, os.F_OK | os.R_OK):
-            raise ValueError("Missing (or not readable) key "
-                             "file: '%s'" % (self.key))
         key = RSA.importKey(self.key)
         hash_func = SHA256.new(message)
         signer = PKCS1_v1_5.new(key)


Mime
View raw message