libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From atsaki <...@git.apache.org>
Subject [GitHub] libcloud pull request: [LIBCLOUD-593] CloudStack driver's create_n...
Date Sat, 05 Jul 2014 10:59:21 GMT
GitHub user atsaki opened a pull request:

    https://github.com/apache/libcloud/pull/336

    [LIBCLOUD-593] CloudStack driver's create_node fails to join network_id ...

    CloudStack driver's create_node accept an argument "networks" it is used to specify networks
the node will be connected to.
    networks is a list of CloudStackNetwork instances and their id is joined to construct
a argument for CloudStack API's deployVirtualMachine in create_node. It is OK when network
id is string but some implementation uses integer network id.
    When network id is integer, the code like following fails.
    networks = driver.ex_list_networks()
    node = driver.create_node(location, image, size, networks=networks)
    This patch convert network id into str explicitly before joining network ids.
    
    https://issues.apache.org/jira/browse/LIBCLOUD-593

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/atsaki/libcloud 593-convert_network_id_to_str

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #336
    
----
commit a0ad7845a7cd5b380af5a707b69de1b042bedaf9
Author: Atsushi Sasaki <atsaki01@gmail.com>
Date:   2014-07-05T10:55:22Z

    [LIBCLOUD-593] CloudStack driver's create_node fails to join network_id when network_id
is int

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message