libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zerthimon <...@git.apache.org>
Subject [GitHub] libcloud pull request: allow specifying standard as a domain in ex...
Date Wed, 02 Jul 2014 16:02:14 GMT
GitHub user zerthimon opened a pull request:

    https://github.com/apache/libcloud/pull/335

    allow specifying standard as a domain in ex_associate_address_with_node

    AWS uses "domain" field to distinguish between EIP allocated for Classic EC2 ('standard')
and EIPs allocated for VPC (value 'vpc')
    
    domain
        Indicates whether this Elastic IP address is for use with instances in EC2-Classic
(standard) or instances in a VPC (vpc).
        Type: xsd:string
        Valid values: standard | vpc
    
    http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-ItemType-DescribeAddressesResponseItemType.html
    
    The method ex_allocate_address() also uses 'standard' and 'vpc' as allowed parameters.
    
    This patch adds 'standard' as a value to domain parameter.
    None is left for backward compatibility.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zerthimon/libcloud use_standard_domain

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #335
    
----
commit 586a6e30d1f468b25b6c83698c8f721220c0ba59
Author: Lior Goikhburg <goikhburg@gmail.com>
Date:   2014-07-02T15:42:24Z

    allow specifying standard as a domain in ex_associate_address_with_node()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message