libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Csaba Hoch (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-567) Openstack driver returns a 404 when listing pool of available ips for HPcloud
Date Thu, 29 May 2014 09:20:01 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012213#comment-14012213
] 

Csaba Hoch commented on LIBCLOUD-567:
-------------------------------------

{quote}
It should be:
{noformat}
/os-floating-ips
{noformat}
instead of
{noformat}
/os-floating-ip-pools
{noformat}
{quote}

The OpenStack_1_1_NodeDriver.ex_list_floating_ip_pools function (https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/openstack.py#L2169)
is correct the way it is, because it lists IP address pools, not IP addresses. Making it list
IP addresses instead of IP address pools in case of certain providers is not the best solution.

Instead a new ex_list_floating_ip function could be used to list the IP addresses.

Fortunately, as Tomaz mentions, this was just implemented and merged :)

{quote}
Should
{noformat}
ex_list_floating_ip_pools
{noformat}
be implemented in the hpcloud driver instead?
{quote}

I think it is better to have this functionality available from the general OpenStack driver,
because there may be other OpenStack clouds that don't support floating IP address pools,
only floating IP addresses.

{quote}
I do agree that shoving all the extension methods on the base driver is not ideal. I think
we should use a mixin model. We define `OpenStackFloatingIPsMixin` which defines this functionality
and then we have HP Cloud driver also inherit from this mixin.
{quote}

The mixin model sounds good. We could even make the OpenStack_1_1_FloatingIpPool class inherit
from that mixin to have less code duplication between OpenStack_1_1_FloatingIpPool and OpenStack_1_1_NodeDriver.


> Openstack driver returns a 404 when listing pool of available ips for HPcloud
> -----------------------------------------------------------------------------
>
>                 Key: LIBCLOUD-567
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-567
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.14.0-beta3
>            Reporter: Jesus Zambrano
>
> Resource request here:
> https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/openstack.py#L2169
> returns a 404 for HPCloud.
> It should be:
> {code}/os-floating-ips{code} instead of {code}/os-floating-ip-pools{code} according to
the hpcloud docs found here:
> https://docs.hpcloud.com/api/v13/compute/#listFloatingIPs
> Should {noformat} ex_list_floating_ip_pools {noformat} be implemented in the hpcloud
driver instead?
> https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/hpcloud.py



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message