libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-563) Reserved variable name "id" is used in many methods of ec2 driver
Date Mon, 26 May 2014 12:45:02 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008808#comment-14008808
] 

ASF GitHub Bot commented on LIBCLOUD-563:
-----------------------------------------

GitHub user zerthimon opened a pull request:

    https://github.com/apache/libcloud/pull/300

    LIBCLOUD-563 fix group id variable

    Fix variable name.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zerthimon/libcloud LIBCLOUD-563_group_id_variable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #300
    
----
commit f91a42e08691fbb8181862b51272cb293c26d7b8
Author: Lior Goikhburg <goikhburg@gmail.com>
Date:   2014-05-26T12:42:21Z

    LIBCLOUD-563 fix group id variable

----


> Reserved variable name "id" is used in many methods of ec2 driver
> -----------------------------------------------------------------
>
>                 Key: LIBCLOUD-563
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-563
>             Project: Libcloud
>          Issue Type: Bug
>            Reporter: Lior Goikhburg
>
> There is a bug in ec2 driver method ex_authorize_security_group_ingress is broken, and
I expect all other methods, that use a reserved name "id" as a variable name in ec2 driver
> example:
> https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/ec2.py#L2708
> https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/ec2.py#L2747
> exception:
> {code}
> > provider.connection.ex_authorize_security_group_ingress('sg-c8fb14ad', '669', '669',
cidr_ips='100.100.4.0/24')
> *** Exception: InvalidGroupId.Malformed: Invalid id: "<built-in function id>" (expecting
"sg-...")
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message