libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-547) linode labels - 1 to 48 chars
Date Tue, 29 Apr 2014 15:15:17 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984381#comment-13984381
] 

ASF GitHub Bot commented on LIBCLOUD-547:
-----------------------------------------

GitHub user earthgecko opened a pull request:

    https://github.com/apache/libcloud/pull/286

    [LIBCLOUD-547]

    Using linode["id"] for labels and the labels step needed to be moved down to after the
linode object exists so that the id can be used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/earthgecko/libcloud LIBCLOUD-547

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #286
    
----
commit c2451f4e37f6823fec55fde00f88f1376eb3d999
Author: Gary Wilson <@earthgecko>
Date:   2012-05-31T17:50:36Z

    IssueID #201 LIBCLOUD-201
    zone.id changed to zone in lines 433 and 434
    Modified:
    libcloud/dns/drivers/zerigo.py

commit 6b45f6a5c188a1172c21da19e34cec026e447863
Author: Gary Wilson <@earthgecko>
Date:   2012-05-31T17:59:52Z

    IssueID #201 LIBCLOUD-201
    Restored original:
    libcloud/dns/drivers/zerigo.py

commit db66910eec5f7d3d9046112c8cc73a12ec817b6f
Author: earthgecko <gary.wilson@of-networks.co.uk>
Date:   2014-04-29T14:20:57Z

    Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/libcloud into trunk

commit 990ffe9fba172aaef2af23ba2ebe7dae60b3b084
Author: earthgecko <gary.wilson@of-networks.co.uk>
Date:   2014-04-29T14:28:57Z

    IssueID #547: linode.py labels too long with name use linode id instead

commit 664c858895de56c288c7681c5126c5b8a49da8e4
Author: earthgecko <gary.wilson@of-networks.co.uk>
Date:   2014-04-29T14:49:46Z

    Update trunk

commit 5622e18ca22a91a519f1cc7bca05d8d23ed1cd01
Author: earthgecko <gary.wilson@of-networks.co.uk>
Date:   2014-04-29T14:51:14Z

    IssueID #547: linode.py labels too long with name use linode id instead

commit 5fd94c90fd4d30c0f86fe54178930a4de1fc6152
Author: earthgecko <gary.wilson@of-networks.co.uk>
Date:   2014-04-29T14:59:19Z

    Update trunk

commit 6853d05c6082f53fafc8f29b7a8e9ef38c99052d
Author: earthgecko <gary.wilson@of-networks.co.uk>
Date:   2014-04-29T15:04:52Z

    [LIBCLOUD-547] linode.py labels too long with name use linode id instead

commit 9698e989b5dda132a856aedb90c3cd9518e6e6d3
Author: earthgecko <gary.wilson@of-networks.co.uk>
Date:   2014-04-29T15:08:57Z

    Merge branch 'LIBCLOUD-547' of github.com:earthgecko/libcloud into LIBCLOUD-547

commit 046cca6da0238c95f468f868ed0224f5678a0258
Author: earthgecko <gary.wilson@of-networks.co.uk>
Date:   2014-04-29T15:09:20Z

    [LIBCLOUD-547] linode.py labels too long with name use linode id instead

----


> linode labels - 1 to 48 chars
> -----------------------------
>
>                 Key: LIBCLOUD-547
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-547
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.14.0-beta3
>            Reporter: Gary Wilson
>              Labels: linode
>
> The labels generated in libcloud/compute/drivers/linode.py are limited in length, however
seeing as the name is using the node name which is a hostname and can be up to 63 characters
as per RFC 1034, the generated labels can result in a string longer than the allowed 48 characters.
> In this instance the name was zpf-watcher-dev-2-96g-luk1
> [zpf-watcher-dev-2-96g-luk1] Configuration Profile = 51 chars
> Perhaps the linode["id"] could be used instead of name as the name could be longer than
48 chars
> libcloud/compute/drivers/linode.py
> {code}
>         # Labels
>         label = {
>             "lconfig": "[%s] Configuration Profile" % name,
>             "lroot": "[%s] %s Disk Image" % (name, image.name),
>             "lswap": "[%s] Swap Space" % name
>         }
>         for what in ["lconfig", "lroot", "lswap"]:
>             if what in kwargs:
>                 label[what] = kwargs[what]
> {/code}
> {code}
>   File "/usr/lib/python2.6/site-packages/libcloud/compute/drivers/linode.py", line 361,
in create_node
>     data = self.connection.request(API_ROOT, params=params).objects[0]
>   File "/usr/lib/python2.6/site-packages/libcloud/common/base.py", line 675, in request
>     response = responseCls(**kwargs)
>   File "/usr/lib/python2.6/site-packages/libcloud/common/linode.py", line 105, in __init__
>     raise self.errors[0]
> libcloud.common.linode.LinodeException: (8) Invalid Label length - must be between 1
and 48 characters
> {/code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message