libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sebastien goasguen (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (LIBCLOUD-462) ex_allocate_public_ip and ex_release_public_ip method on the CloudStackNode class is broken
Date Wed, 18 Dec 2013 12:42:08 GMT

     [ https://issues.apache.org/jira/browse/LIBCLOUD-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

sebastien goasguen reassigned LIBCLOUD-462:
-------------------------------------------

    Assignee: sebastien goasguen

> ex_allocate_public_ip and ex_release_public_ip method on the CloudStackNode class is
broken
> -------------------------------------------------------------------------------------------
>
>                 Key: LIBCLOUD-462
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-462
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>            Reporter: Tomaz Muraus
>            Assignee: sebastien goasguen
>            Priority: Minor
>
> ex_allocate_public_ip and ex_release_public_ip method on the CloudStackNode class appears
to be broken.
> Both of those methods call respective methods on the driver class with invalid arguments.
They pass node object to the driver method, but the driver method doesn't take a node object.
> See:
> * https://github.com/apache/libcloud/blob/4b76b9a7980b0dabc027c0c0071f279615578efb/libcloud/compute/drivers/cloudstack.py#L39
& https://github.com/apache/libcloud/blob/4b76b9a7980b0dabc027c0c0071f279615578efb/libcloud/compute/drivers/cloudstack.py#L828
> * https://github.com/apache/libcloud/blob/4b76b9a7980b0dabc027c0c0071f279615578efb/libcloud/compute/drivers/cloudstack.py#L43
& https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/cloudstack.py#L847
> We have two options:
> 1. Fix those methods to actually do what the docstring says - allocate the IP *and bind
it to the node*
> 2. Remove those methods from the CloudStackNode class since in the current form, they
don't belong there.
> We also need better test coverage to detect issues like this automatically in the future.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message