libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tomaz Muraus (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-381) Simplified public ip allocation/release and added port forwarding rule
Date Thu, 22 Aug 2013 15:53:51 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747609#comment-13747609
] 

Tomaz Muraus commented on LIBCLOUD-381:
---------------------------------------

Thanks, here are a couple of comments:

1. Please underscore separated variable names (publicport -> public port, privateport ->
private_port, ...).

I know some of the existing variable in the driver, but we should do it right and be consistent
with other drivers going forward.

2. There is a typo in the docstring - virtualmachine -> node

3. There are a couple of missing docstrings (ex_allocate_public_ip doesn't include a docstring
for location argument, etc.)

4. ex_release_public_ip method is backward incompatible so we should clearly document this
in the change log and upgrading page (this is more of a note to myself)
                
> Simplified public ip allocation/release and added port forwarding rule
> ----------------------------------------------------------------------
>
>                 Key: LIBCLOUD-381
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-381
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>            Reporter: sebastien goasguen
>         Attachments: libcloud381.patch
>
>
> It started as a small patch and ended a little bigger than expected.
> Simplified some IP allocation/release
> Fixed the CloudStackNetwork class
> Modified CloudStackAddress class
> Added CloudStackPortForwarding class
> Added attributed to node for port_forwarding_rules
> Added list_public_ips and test...
> It's lacking a few tests but I would appreciate if you could commit to trunk so I can
build on this.
> thanks

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message