libcloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomaž Muraus <to...@cloudkick.com>
Subject Re: [libcloud] SSL certs checking
Date Tue, 16 Nov 2010 00:38:31 GMT
I have fixed the alt_names and licensing issue and added some tests.

On Sat, Nov 13, 2010 at 6:13 PM, Jed Smith <jed@jedsmith.org> wrote:

> 2010/11/12 Tomaž Muraus <tomaz@cloudkick.com>
>
> > I have made a few modification to your patch, namely if M2Crypto library
> is
> > not available, it uses a custom HTTPS connection module which verifies
> the
> > server certificate.
> >
>
> The license on httplib_ssl.py means we cannot accept that file. Homogeneous
> licensing is necessary as part of our involvement in the Apache Software
> Foundation.
>
> Also, a quick test on my machine resulted in a fairly quick traceback:
>
> Python 2.7 (r27:82500, Oct 20 2010, 03:21:03)
> [GCC 4.5.1] on linux2
> Type "help", "copyright", "credits" or "license" for more information.
> >>> from libcloud.drivers.linode import LinodeNodeDriver
> >>> z = LinodeNodeDriver("nGDJ.....")
> >>> z.list_nodes()
> Traceback (most recent call last):
>  File "<stdin>", line 1, in <module>
>  File "libcloud/drivers/linode.py", line 232, in list_nodes
>    data = self.connection.request(LINODE_ROOT, params=params).objects[0]
>  File "libcloud/base.py", line 484, in request
>    headers=headers)
>  File "/usr/lib/python2.7/httplib.py", line 946, in request
>    self._send_request(method, url, body, headers)
>  File "/usr/lib/python2.7/httplib.py", line 987, in _send_request
>    self.endheaders(body)
>  File "/usr/lib/python2.7/httplib.py", line 940, in endheaders
>    self._send_output(message_body)
>  File "/usr/lib/python2.7/httplib.py", line 803, in _send_output
>    self.send(msg)
>  File "/usr/lib/python2.7/httplib.py", line 755, in send
>    self.connect()
>  File "libcloud/httplib_ssl.py", line 50, in connect
>    if not self._verify_hostname(self.host, cert):
>  File "libcloud/httplib_ssl.py", line 57, in _verify_hostname
>    if (hostname == common_name) or hostname in alt_names:
> TypeError: argument of type 'NoneType' is not iterable
> >>>
>
> Looks like alt_names is None?
>
> J
>

Mime
View raw message