kylin-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luke Han <luke...@gmail.com>
Subject Re: Bash-script improvement proposals
Date Wed, 28 Oct 2015 01:25:20 GMT
Hi Seb,
    Once you done this, you will be able to contribute more not only to
Kylin and also other projects:) Open source needs everyone's contribution;)

    Looking forward for your first patch, we will help you to review and
address the right one:)

    Thanks.


Best Regards!
---------------------

Luke Han

On Tue, Oct 27, 2015 at 11:50 PM, <hd2@uni.de> wrote:

> Hi Shaofeng,
>
> sure thing! Adding a Jira is no problem, but I'm pretty unfamiliar
> with creating a (git)patch. I found the "How to contribute" page at
> kylin.io and will try my best (hopefully it works out ;)).
>
> -Seb
>
> >Hi Seb, you're right; would you mind to open an Apache JIRA to us? of
> >course if you can contribute a patch that would be great; We do have big
> >room to improve, would welcome all contributions from community.
> >
> >Thanks!
>
> >2015-10-27 17:08 GMT+08:00 <hd2@uni.de>:
>
> > Hello again :),
> >
> > after trying out the newest Kylin build (1.2-hbase), I came across
> > some minor issues (HDP 2.3 stack) with two bash-scripts located in
> > /bin/.
> >
> > 1) find-hive-dependency.sh
> > In HDP 2.3, hcatalog is located in ../hive-hcatalog - so if you run
> > the find-dependency script, it fails with "hcatalog lib not found".
> >
> > This is due to the line:
> > hive_home=`echo $hive_exec_path | awk -F '/lib/' '{print $1}'`/
> >
> > It forces the script to use find in e.g. /usr/hdp/2.3.0.0-2557/hive/
> > (which does not include hcatalog files).
> > If you change the following two lines, the script will also search in
> > /hive-hcatalog/ and the error disappears (remove trailing slash and
> > add wildcard operator):
> >
> > # line 39
> > hive_home=`echo $hive_exec_path | awk -F '/lib/' '{print $1}'`
> >
> > # line 41
> > hcatalog=`find $hive_home* -name "hive-hcatalog-core[0-9\.-]*jar" 2>&1
> > | grep -m 1 -v 'Permission denied'`
> >
> >
> > 2) kylin.sh
> > If you run the kylin.sh script without any parameters (GNU bash), it
> > will output the following errors:
> > ./kylin.sh: line 25: [: ==: unary operator expected
> > ./kylin.sh: line 96: [: ==: unary operator expected
> > usage: kylin.sh start or kylin.sh stop
> >
> > Changing the following to lines will "fix" this (add "" around the $1
> > parameter):
> >
> > # line 25
> > if [ "$1" == "start" ]
> >
> > # line 96
> > elif [ "$1" == "stop" ]
> >
> > -Seb
> >
>
>
>
> >--
> >Best regards,
> >
> >Shaofeng Shi
>

Mime
View raw message