kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kylin] zzcclp commented on a change in pull request #1259: KYLIN-4567 Improve TopN merge performance in MR engine
Date Wed, 08 Jul 2020 08:14:51 GMT

zzcclp commented on a change in pull request #1259:
URL: https://github.com/apache/kylin/pull/1259#discussion_r451364156



##########
File path: core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNCounter.java
##########
@@ -43,8 +43,10 @@
 public class TopNCounter<T> implements Iterable<Counter<T>>, java.io.Serializable
{
 
     public static final int EXTRA_SPACE_RATE = 50;
+    public static final int EXTRA_SORT_RATE = 10;

Review comment:
       Why use 10 as default value?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message