kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kylin] codecov-io edited a comment on issue #1064: KYLIN-4328 Add cache for succeed jobid in defaultFetcherRunner
Date Fri, 31 Jan 2020 07:57:39 GMT
codecov-io edited a comment on issue #1064: KYLIN-4328 Add cache for succeed jobid in defaultFetcherRunner
URL: https://github.com/apache/kylin/pull/1064#issuecomment-574948761
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1064?src=pr&el=h1) Report
   > Merging [#1064](https://codecov.io/gh/apache/kylin/pull/1064?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/63d151c6f2ab9df232474b8823fe93e7635b4245?src=pr&el=desc)
will **increase** coverage by `<.01%`.
   > The diff coverage is `55.55%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1064/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1064?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1064      +/-   ##
   ============================================
   + Coverage     25.04%   25.04%   +<.01%     
   + Complexity     6223     6222       -1     
   ============================================
     Files          1440     1440              
     Lines         87821    87829       +8     
     Branches      12275    12277       +2     
   ============================================
   + Hits          21998    22001       +3     
   - Misses        63664    63667       +3     
   - Partials       2159     2161       +2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1064?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1064/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `12.34% <0%> (ø)` | `44 <0> (ø)` | :arrow_down: |
   | [...lin/job/impl/threadpool/PriorityFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/1064/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvUHJpb3JpdHlGZXRjaGVyUnVubmVyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...pache/kylin/job/impl/threadpool/FetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/1064/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRmV0Y2hlclJ1bm5lci5qYXZh)
| `80.48% <100%> (+1%)` | `11 <0> (ø)` | :arrow_down: |
   | [...ylin/job/impl/threadpool/DefaultFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/1064/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdEZldGNoZXJSdW5uZXIuamF2YQ==)
| `56.66% <100%> (+2.28%)` | `7 <0> (+1)` | :arrow_up: |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1064/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
| `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1064/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   | [...cube/v2/coprocessor/endpoint/CubeVisitService.java](https://codecov.io/gh/apache/kylin/pull/1064/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9jdWJlL3YyL2NvcHJvY2Vzc29yL2VuZHBvaW50L0N1YmVWaXNpdFNlcnZpY2UuamF2YQ==)
| `67.75% <0%> (ø)` | `16% <0%> (ø)` | :arrow_down: |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1064/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `69.6% <0%> (+0.3%)` | `7% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1064?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1064?src=pr&el=footer).
Last update [63d151c...67b229b](https://codecov.io/gh/apache/kylin/pull/1064?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message